The film's production budget is ₹2.1 billion (US$29 million), making it the most expensive Yash Raj Films productions, along with Tiger Zinda Hai (2017).Filming commenced on 5 June 2017 in Malta. The film was shot in Mehrangarh Fort, Jodhpur. It was also filmed in Thailand. The film's climax will be filmed in Rajasthan.
Amitabh Bachchan suffered with neck and back pain due to the heavy clothing and stunts in the film.
This is Khan's second time collaborating with Vijay Krishna Acharya and Katrina Kaif, after Dhoom 3 (2013).The film will have a dance sequence featuring Bachchan, choreographed by Prabhu Deva. It will also reportedly feature sea battles similar to ones seen in films such as Pirates of the Caribbean.
Jackie Shroff was to be a part of the film, but had to turn the role down due to conflicting commitments.